Re: Linux 5.18-rc4

From: Linus Torvalds
Date: Mon Apr 25 2022 - 18:23:28 EST


On Mon, Apr 25, 2022 at 2:27 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Subject: mm/nommu.c: provide vmalloc_huge() for CONFIG_MMU=n

Note, should already be fixed differently (with an alias) by

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0fc74d820a012550be006ba82dd8f1e3fe6fa9f7

although when I looked at the random collection of vmalloc things it
did make me go "hmm".

It might be a better long-term idea to only implement the very generic
low-level function in mm/vmalloc.c and mm/nommu.c (ie the
__vmalloc_node_range() function) and then move all the random wrapper
functions into mm/util.c.

Because right now we effectively duplicate all those wrapper
functions, which is kind of ugly.

Linus