Re: [PATCH 3/4] tools/bpf: musl compat: replace nftw with FTW_ACTIONRETVAL

From: Quentin Monnet
Date: Mon Apr 25 2022 - 18:24:48 EST


On Sun, 24 Apr 2022 at 06:11, Dominique Martinet <asmadeus@xxxxxxxxxxxxx> wrote:
>
> musl nftw implementation does not support FTW_ACTIONRETVAL.
>
> There have been multiple attempts at pushing the feature in musl
> upstream but it has been refused or ignored all the times:
> https://www.openwall.com/lists/musl/2021/03/26/1
> https://www.openwall.com/lists/musl/2022/01/22/1
>
> In this case we only care about /proc/<pid>/fd/<fd>, so it's not
> too difficult to reimplement directly instead, and the new
> implementation makes 'bpftool perf' slightly faster because it doesn't
> needlessly stat/readdir unneeded directories (54ms -> 13ms on my machine)
>
> Signed-off-by: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>

Acked-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>