Re: [PATCH v3 06/21] x86/virt/tdx: Shut down TDX module in case of error

From: Kai Huang
Date: Mon Apr 25 2022 - 22:12:15 EST



> >
> > Prevent all SEAMCALLs on other LPs except TDH.SYS.LP.SHUTDOWN. The spec defnies
> > shutting down the TDX module as running this SEAMCALl on all LPs, so why just
> > run on a single cpu? What's the benefit?
>
> If executing it in one LP prevents SEAMCALLs on all other LPs, I am
> trying to understand why spec recommends running it in all LPs?

Please see 3.1.2 Intel TDX Module Shutdown and Update

The "shutdown" case requires "Execute On" on "Each LP".

Also, TDH.SYS.LP.SHUTDOWN describe this is shutdown on *current* LP.

>
> But the following explanation answers my query. I recommend making a
> note about it in commit log or comments.

Is above enough to address your question?



--
Thanks,
-Kai