Re: [PATCH] null-blk: save memory footprint for struct nullb_cmd

From: Chaitanya Kulkarni
Date: Tue Apr 26 2022 - 02:20:31 EST

On 4/25/22 19:21, Yu Kuai wrote:
> Total 16 bytes can be saved in two ways:
> 1) The field 'bio' will only be used in bio based mode, and the field
> 'rq' will only be used in mq mode. Since they won't be used in the
> same time, declare a union for them.
> 2) The field 'bool fake_timeout' can be placed in the hole after the
> field 'error'.
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>