Re: [PATCH v3 0/2] Enable EAS for CPPC/ACPI based systems

From: Pierre Gondois
Date: Tue Apr 26 2022 - 03:10:46 EST

Hello Viresh,
The 2 patches are relying on Lukasz' patch-set at:
The serie was accepted by Rafael (cf. and
is currently in linux-next. More specifically, the missing patch causing the
build failure is: 'PM: EM: Add .get_cost() callback'

From what I see, the branch cpufreq/arm/linux-next (from your repo) that was
used in the CI is based on v5.18-rc1 and doesn't have Lukasz' patches. Should
we wait for the patches to be in a rc version, or is there a process for this
kind of case ?


On 4/26/22 08:37, Viresh Kumar wrote:
On 26-04-22, 08:38, Viresh Kumar wrote:
On 25-04-22, 14:38, Pierre Gondois wrote:
- Remove efficiency_class_populated variable. [Viresh]
- Remove patch "cpufreq: CPPC: Add cppc_cpufreq_search_cpu_data"
and access cpu_data through policy->driver_data. [Viresh]
- arm64 code only acked by Catalin [Catalin]

Applied. Thanks.

Removed, build failures:


/builds/linux/drivers/cpufreq/cppc_cpufreq.c: In function 'cppc_cpufreq_register_em':
368/builds/linux/drivers/cpufreq/cppc_cpufreq.c:593:3: error: implicit declaration of function 'EM_ADV_DATA_CB'; did you mean 'EM_DATA_CB'? [-Werror=implicit-function-declaration]
369 593 | EM_ADV_DATA_CB(cppc_get_cpu_power, cppc_get_cpu_cost);
370 | ^~~~~~~~~~~~~~
371 | EM_DATA_CB
372/builds/linux/drivers/cpufreq/cppc_cpufreq.c:593:3: error: invalid initializer
373cc1: some warnings being treated as errors