Re: [PATCH] plat-omap: check return value of ioremap()

From: Tony Lindgren
Date: Tue Apr 26 2022 - 04:05:40 EST


Hi,

* Ren Yu <renyu@xxxxxxxxxxxx> [220425 11:08]:
> When ioremap() failed,return err

This file is no longer being used and getting removed in Linux next.
See commit 7058e68c2fed ("ARM: omap: remove debug-leds driver").

Thanks,

Tony

> Signed-off-by: Ren Yu <renyu@xxxxxxxxxxxx>
> ---
> arch/arm/plat-omap/debug-leds.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/plat-omap/debug-leds.c b/arch/arm/plat-omap/debug-leds.c
> index 2b698d074874..bf5034e10f6e 100644
> --- a/arch/arm/plat-omap/debug-leds.c
> +++ b/arch/arm/plat-omap/debug-leds.c
> @@ -109,6 +109,9 @@ static int fpga_probe(struct platform_device *pdev)
> return -ENODEV;
>
> fpga = ioremap(iomem->start, resource_size(iomem));
> + if (!fpga)
> + return -ENOMEM;
> +
> writew_relaxed(0xff, &fpga->leds);
>
> for (i = 0; i < ARRAY_SIZE(dbg_leds); i++) {
> --
> 2.25.1
>