Re: [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition

From: Guenter Roeck
Date: Tue Apr 26 2022 - 04:58:38 EST

On 4/26/22 01:27, liuxp11@xxxxxxxxxxxxxxx wrote:
On 4/26/22 00:10, Liu Xinpeng wrote:
> Using SET_NOIRQ_SYSTEM_SLEEP_PM_OPS reduces redundant code.
> Signed-off-by: Liu Xinpeng <liuxp11@xxxxxxxxxxxxxxx>
> Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
Also, Tzung-Bi never sent a Reviewed-by: tag. As with the other patches,
this is completely inappropriate. Really, who gave you that idea ?
You adding such tags without receiving them means we can never trust
your patches again since you are making things up.
-->Very sorry about this. I am not clearly when need to add "Reviewed-by: tag",
Just expressing thanks.

If you get a Reviewed-by: tag for a patch, you keep it in the next version of
that patch unless there are substantial changes. You _never_ add one yourself.