Re: [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD
From: Greg Kroah-Hartman
Date: Tue Apr 26 2022 - 06:12:34 EST
On Sun, Apr 24, 2022 at 09:44:11AM +0200, Philipp Hortmann wrote:
> Replace macro MACvReadMIBCounter with VNSvInPortD.
> Last patch within this patch series will replace all macros
> VNSvInPortD with ioread32. The names of macros and the arguments
> use CamelCase which is not accepted by checkpatch.pl
No need to say "last patch" as that will not make sense when these are
in the tree, right?
> Since there are more than one checkpatch issue per line,
> more steps are rquired to fix.
This sentance also is not needed.
So the changelog can just say:
Replace macro MACvReadMIBCounter with VNSvInPortD and as it was
the only user, it can now be removed.
Same comments on the other changes in this series, but I did take the
first patch, it made sense on its own.