Re: [PATCH v2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool
From: Andy Shevchenko
Date: Tue Apr 26 2022 - 09:27:12 EST
On Tue, Apr 26, 2022 at 12:10:01PM +0530, Jagdish Gediya wrote:
> At many places in kernel, It is necessary to convert sysfs input
> to corrosponding bool value e.g. "false" or "0" need to be converted
> to bool false, "true" or "1" need to be converted to bool true,
> places where such conversion is needed currently check the input
> string manually, kstrtobool can be utilized at such places but
kstrtobool()
> currently kstrtobool doesn't have support to "false"/"true".
Ditto.
> Add "false"/"true" support to kstrtobool while string conversion
Ditto.
> to bool. Modify existing manual sysfs conversions to use kstrtobool().
> This patch doesn't have any functionality change.
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Petr Mladek <pmladek@xxxxxxxx>
You may use --cc parameter to `git send-email`.
...
> lib/kstrtox.c | 7 +++++++
> mm/migrate.c | 6 +-----
> mm/swap_state.c | 6 +-----
Please, split to two.
Also Documentation update is missed.
--
With Best Regards,
Andy Shevchenko