Re: [PATCH 16/27] modpost: make multiple export error
From: Nick Desaulniers
Date: Tue Apr 26 2022 - 12:40:12 EST
On Mon, Apr 25, 2022 at 9:10 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> On Tue, Apr 26, 2022 at 3:48 AM Nick Desaulniers
> <ndesaulniers@xxxxxxxxxx> wrote:
> > On Sun, Apr 24, 2022 at 12:09 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> > >
> > > This is currently a warning, but I think modpost should stop building
> > > in this case.
> > >
> > > If the same symbol is exported multiple times and we let it keep going,
> > > the sanity check becomes difficult.
> > >
> > > Only the legitimate case is that an external module overrides the
> > > corresponding in-tree module to provide a different implementation
> > > with the same interface.
> > Could the same module export a weak version of a symbol, and a strong one?
> No. There is no concept like EXPORT_SYMBOL_WEAK.
> I am talking about kmod things.
> You can modprobe an external module instead of the in-kernel one.
Ok, this patch seems fine to me.
Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>