Re: [PATCH v3] firmware: arm_scmi: support optee shared memory in optee transport

From: Cristian Marussi
Date: Tue Apr 26 2022 - 12:51:44 EST


On Mon, Apr 25, 2022 at 10:51:27AM +0200, Etienne Carriere wrote:
> Adds support for tee shared memory in optee scmi transport. When using
> tee shared memory, scmi optee transport manages SCMI messages using
> msg protocol (from msg.c) in shared memory, whereas smt (from shmem.c)
> protocol is used with static IOMEM shared buffers.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@xxxxxxxxxx>
> ---
> Changes since v2:
> - Select configuration switch ARM_SCMI_HAVE_MSG when
> ARM_SCMI_TRANSPORT_OPTEE is enabled.
> - Don't consider tee_shm in invoke_process_smt_channel() since
> this function now assumes TEE shared memory is not used for SMT
> based channel.
>
> Changes since v1:
> - Remove call to scmi_rx_callback() in scmi_optee_send_message().
> ---

LGTM

Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx>

Thanks,
Cristian