Re: [PATCH] tty: n_gsm: return -EINVAL when adaption is not supported

From: Tom Rix
Date: Tue Apr 26 2022 - 14:16:46 EST

On 4/26/22 5:12 AM, Greg KH wrote:
On Tue, Apr 26, 2022 at 08:05:54AM -0400, Tom Rix wrote:
The clang build fails with
n_gsm.c:940:13: error: variable 'size' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
} else if (dlci->adaption == 2) {

The else should return an error, so return -EINVAL.

Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
What commit id does this fix? Any reason you didn't cc: the author of
the recent changes to this code?
Sorry missed this part.
Is this the same issue that 0-day reported?

Maybe, it was part of next's update today.  Where is 0-day reported ?



greg k-h