Re: [PATCH v2] x86/pm: fix false positive kmemleak report in msr_build_context()
From: Matthieu Baerts
Date: Tue Apr 26 2022 - 16:08:12 EST
Hi Borislav, Rafael,
Thank you for your reviews!
On 26/04/2022 19:27, Borislav Petkov wrote:
> On Tue, Apr 26, 2022 at 06:24:04PM +0200, Rafael J. Wysocki wrote:
>> So can the comment be dropped entirely?
> Looks like it to me. All the accesses in wakeup_64.S are done through
> those offsets which are computed at build-time so they should always be
> OTOH, I wouldn't mind having there some text making any future person
> touching this, aware of where to look when making changes.
> Some changes like removing a struct member are nicely caught, ofc,
> see below. But for something else which is a lot more subtle having a
> comment say "hey, have a look at where this is used in wakeup_64.S and
> make sure everything is still kosher" is better than having no comment
> at all. IMHO.
Good point, let me update the comment and the commit message in a new v3.
Tessares | Belgium | Hybrid Access Solutions