Re: [PATCH] iommu/dart: check return value after calling platform_get_resource()

From: Sven Peter
Date: Tue Apr 26 2022 - 16:22:32 EST


> On 25. Apr 2022, at 10:56, Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
>
> It will cause null-ptr-deref in resource_size(), if platform_get_resource()
> returns NULL, move calling resource_size() after devm_ioremap_resource() that
> will check 'res' to avoid null-ptr-deref.
> And use devm_platform_get_and_ioremap_resource() to simplify code.
>
> Fixes: 46d1fb072e76 ("iommu/dart: Add DART iommu driver")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Reviewed-by: Sven Peter <sven@xxxxxxxxxxxxx>


Thanks,

Sven