Re: [PATCH v2 1/1] watchdog: sp805: disable watchdog on remove

[Guenter Roeck]

On 4/13/22 22:42, Eliav Farber wrote:
> Disable the watchdog if it is active while removing the module.
> It is necessary in order to prevent a reset in case watchdog
> hw was running before the removal.
>
> Signed-off-by: Eliav Farber <farbere@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Note that sending an introduction is not necessary for individual patches.

Guenter

> ---
>   drivers/watchdog/sp805_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
> index d8876fba686d..69a6182c2dfe 100644
> --- a/drivers/watchdog/sp805_wdt.c
> +++ b/drivers/watchdog/sp805_wdt.c
> @@ -273,6 +273,7 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
>   	watchdog_set_nowayout(&wdt->wdd, nowayout);
>   	watchdog_set_drvdata(&wdt->wdd, wdt);
>   	watchdog_set_restart_priority(&wdt->wdd, 128);
> +	watchdog_stop_on_unregister(&wdt->wdd);
>   
>   	/*
>   	 * If 'timeout-sec' devicetree property is specified, use that.