Re: [PATCH v5 2/2] arm64: dts: Add Mediatek SoC MT8186 dts and evaluation board and Makefile

From: Miles Chen
Date: Tue Apr 26 2022 - 19:01:05 EST


Hi Allen,

> Add basic chip support for Mediatek MT8186.

s/Mediatek/MediaTek/

>
> Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@xxxxxxxxxxxx>

...snip...

> @@ -0,0 +1,232 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)

I think we should use GPL-2.0-only OR BSD-2-Clause for newly added dts files.
i.e.,
// SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause

> +/*
> + * Copyright (C) 2022 MediaTek Inc.
> + */
> +/dts-v1/;
> +#include "mt8186.dtsi"
> +
> +/ {


..snip...

> diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> new file mode 100644
> index 000000000000..e8d8867412e3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> @@ -0,0 +1,932 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)

I think we should use GPL-2.0-only OR BSD-2-Clause for newly added dts files.
i.e.,
// SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause

> +/*
> + * Copyright (C) 2022 MediaTek Inc.
> + * Author: Allen-KH Cheng <allenn-kh.cheng@xxxxxxxxxxxx>
> + */
> +/dts-v1/;
>


thanks,
Miles