Re: [PATCH v3 0/3] staging: vme: Cleanup driver tree old structures

From: Bruno Moreira-Guedes
Date: Wed Apr 27 2022 - 08:19:05 EST


Hello,

On Fri, Apr 22, 2022 at 08:39:36AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 21, 2022 at 08:16:05PM +0100, Martyn Welch wrote:
> > On Wed, 2022-04-20 at 18:43 +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Apr 18, 2022 at 08:29:49PM -0300, Bruno Moreira-Guedes wrote:
> > > > This patch series modify the vme_user driver's place in
> > > > menuconfig (1/3), fixes a missing `depends on` line in a Kconfig
> > > > file
> > > > (2/3), and rearrages the directory tree for the driver allowing a
> > > > more
> > > > straightforward comprehension of its contents (3/3).
> > > >
> > > > The 'vme_user/' driver is the only remaining vme-family driver in
> > > > the
> > > > 'staging/' tree, but its structure, entry in menuconfig and
> > > > building
> > > > routines are still attached to the 'vme/' subtree now outside
> > > > 'staging/'. The present patchset fixes it.
> > > >
> > > > Signed-off-by: Bruno Moreira-Guedes <codeagain@xxxxxxxxxxxxx>
> > >
> > > What about deleting the vme drivers entirely?
> >
> > I assume you're suggesting deleting the "vme_user" driver from the
> > staging directory?
>
> Yes, at the very least given that no one has tried to fix it up and get
> it out of staging in many years.

While I cannot comment anything on that regard, I imagine the v4 I sent
a couple of days ago will wait for that decision, right?

Should I prepare a patch removing them and also submit so when it's
decided you can just pick one patch or the other?

>
> > > Martyn, anyone still using these?
> > >
> >
> > I'm fairly sure that the actual VME drivers for the hardware bridges
> > (the bits not in staging) are still being used based on the
> > conversations I've had today. I'm just trying to find out whether the
> > vme_user bit is actively being used.
>
> If the non-staging vme drivers are still being used, that's great. But
> if not, those too should be dropped.
>
> thanks,
>
> greg k-h

Attachment: signature.asc
Description: PGP signature