RE: [PATCH 06/10] dt-bindings: mfd: samsung,exynos5433-lpass: fix 'dma-channels/requests' properties

[Alim Akhtar]

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
>Sent: Wednesday, April 27, 2022 9:29 PM
>To: Lee Jones <lee.jones@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar
><alim.akhtar@xxxxxxxxxxx>; Dinh Nguyen <dinguyen@xxxxxxxxxx>; Michal
>Simek <michal.simek@xxxxxxxxxx>; Liviu Dudau <liviu.dudau@xxxxxxx>;
>Sudeep Holla <sudeep.holla@xxxxxxx>; Lorenzo Pieralisi
><lorenzo.pieralisi@xxxxxxx>; Ray Jui <rjui@xxxxxxxxxxxx>; Scott Branden
><sbranden@xxxxxxxxxxxx>; Broadcom Kernel Team <bcm-kernel-feedback-
>list@xxxxxxxxxxxx>; Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>;
>devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Rob Herring
><robh@xxxxxxxxxx>
>Subject: [PATCH 06/10] dt-bindings: mfd: samsung,exynos5433-lpass: fix
>'dma-channels/requests' properties
>
>pl330 DMA controller bindings documented 'dma-channels' and 'dma-
>requests' properties (without leading hash sign), so fix the DTS to match
the
>bindings.
>
>Reported-by: Rob Herring <robh@xxxxxxxxxx>
>Fixes: e18183cefc8b ("mfd: Add DT bindings documentation for Samsung
>Exynos LPASS")
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>---
Looking at Documentation/devicetree/bindings/dma/dma-common.yaml
This change looks good.

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>


> .../devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml     | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-
>lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-
>lpass.yaml
>index f7bb67d10eff..b97b06848729 100644
>--- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-
>lpass.yaml
>+++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-
>lpass.yam
>+++ l
>@@ -79,8 +79,8 @@ examples:
>             clocks = <&cmu_aud CLK_ACLK_DMAC>;
>             clock-names = "apb_pclk";
>             #dma-cells = <1>;
>-            #dma-channels = <8>;
>-            #dma-requests = <32>;
>+            dma-channels = <8>;
>+            dma-requests = <32>;
>             power-domains = <&pd_aud>;
>         };
>
>--
>2.32.0