Re: [PATCH v4 00/10] Add Copy offload support
From: Damien Le Moal
Date: Wed Apr 27 2022 - 17:56:19 EST
On 4/28/22 00:38, Nitesh Shetty wrote:
> On Wed, Apr 27, 2022 at 10:46:32AM +0900, Damien Le Moal wrote:
>> On 4/26/22 19:12, Nitesh Shetty wrote:
>>> The patch series covers the points discussed in November 2021 virtual call
>>> [LSF/MM/BFP TOPIC] Storage: Copy Offload.
>>> We have covered the Initial agreed requirements in this patchset.
>>> Patchset borrows Mikulas's token based approach for 2 bdev
>>> Overall series supports –
>>> 1. Driver
>>> - NVMe Copy command (single NS), including support in nvme-target (for
>>> block and file backend)
>>> 2. Block layer
>>> - Block-generic copy (REQ_COPY flag), with interface accommodating
>>> two block-devs, and multi-source/destination interface
>>> - Emulation, when offload is natively absent
>>> - dm-linear support (for cases not requiring split)
>>> 3. User-interface
>>> - new ioctl
>>> - copy_file_range for zonefs
>>> 4. In-kernel user
>>> - dm-kcopyd
>>> - copy_file_range in zonefs
>>> For zonefs copy_file_range - Seems we cannot levearge fstest here. Limited
>>> testing is done at this point using a custom application for unit testing.
>> ./configure --with-tests
>> sudo make install
>> Then run tests/zonefs-tests.sh
>> Adding test case is simple. Just add script files under tests/scripts
>> I just realized that the README file of this project is not documenting
>> this. I will update it.
> Thank you. We will try to use this.
> Any plans to integrate this testsuite with fstests(xfstest) ?
No. It is not a good fit since zonefs cannot pass most of the generic test
> Nitesh Shetty
Damien Le Moal
Western Digital Research