Re: ndctl tests usable?

From: Shivaprasad G Bhat
Date: Thu Apr 28 2022 - 00:37:19 EST


On 4/26/22 23:39, Michal Suchánek wrote:
On Tue, Apr 26, 2022 at 09:47:19AM -0700, Dan Williams wrote:
On Tue, Apr 26, 2022 at 9:43 AM Michal Suchánek <msuchanek@xxxxxxx> wrote:

On Tue, Apr 26, 2022 at 09:32:24AM -0700, Dan Williams wrote:
On Tue, Apr 26, 2022 at 9:15 AM Michal Suchánek <msuchanek@xxxxxxx> wrote:

On Tue, Apr 26, 2022 at 08:51:25AM -0700, Dan Williams wrote:
On Tue, Apr 26, 2022 at 5:39 AM Michal Suchánek <msuchanek@xxxxxxx> wrote:

...

The modinfo just tells you what modules are available, but it does not
necessarily indicate which modules are actively loaded in the system
which is what ndctl_test_init() validates.

Isn't what modinfo lists also what modrobe loads?

<snip>

modules are not loaded before the test.

Maybe something goes wrong with the test module build?

It is very fragile and requires complete kernel source for each
configuration built. See below for the package

https://build.opensuse.org/package/show/home:michals/nfit_test

Attaching the log of test run which does not report any missing tools,
only complains about nfit.ko being production.

I have attempted to fix few of the known issues in the first 3 patches of the series posted here.

https://patchwork.kernel.org/project/linux-nvdimm/list/?series=633103


Thanks

Michal