Re: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

From: Herve Codina
Date: Thu Apr 28 2022 - 05:28:01 EST


Hi Sergey,

On Sat, 23 Apr 2022 19:41:09 +0300
Sergey Shtylyov <s.shtylyov@xxxxxx> wrote:

> On 4/23/22 12:09 PM, Sergey Shtylyov wrote:
>
> [...]
> >> Define the r9a06g032 generic part of the USB PHY device node.
> >>
> >> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> >> ---
> >> arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
> >> index 33581f0c55c4..58af07eb75c9 100644
> >> --- a/arch/arm/boot/dts/r9a06g032.dtsi
> >> +++ b/arch/arm/boot/dts/r9a06g032.dtsi
> >> @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk {
> >> clock-frequency = <0>;
> >> };
> >>
> >> + usbphy: usbphy {
> >
> > I think the node name should be "usb-phy"...
>
> It's not my thinking alone, the DT spec documents "usb-phy" in section 2.2.2. :-)

Will be changed in v4.

Thanks for pointing this.

Regards,
Hervé

--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com