Re: [PATCH v2] iommu/msm: add a check for the return of kzalloc()

From: Joerg Roedel
Date: Thu Apr 28 2022 - 06:25:19 EST


On Thu, Apr 28, 2022 at 04:52:39PM +0800, xkernel.wang@xxxxxxxxxxx wrote:
> From: Xiaoke Wang <xkernel.wang@xxxxxxxxxxx>
>
> kzalloc() is a memory allocation function which can return NULL when
> some internal memory errors happen. So it is better to check it to
> prevent potential wrong memory access.
>
> Besides, to propagate the error to the caller, the type of
> insert_iommu_master() is changed to `int`. Several instructions related
> to it are also updated.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@xxxxxxxxxxx>
> ---
> ChangeLog:
> v1->v2 propagate the error to the caller.
> drivers/iommu/msm_iommu.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)

Applied, thanks.