Re: [PATCH v8 2/2] arm64: dts: Add MediaTek SoC MT8186 dts and evaluation board and Makefile

From: Nícolas F. R. A. Prado
Date: Thu Apr 28 2022 - 13:28:09 EST


Hi Allen,

On Thu, Apr 28, 2022 at 02:17:17PM +0800, Allen-KH Cheng wrote:
> + scp: scp@10500000 {
> + compatible = "mediatek,mt8186-scp";
> + reg = <0 0x10500000 0 0x40000>,
> + <0 0x105c0000 0 0x19080>;
> + reg-names = "sram", "cfg";

The mtk,scp dt-binding should be updated as it currently doesn't allow l1tcm to
be missing. According to comments in the driver cfg is optional as well, so a
patch to the binding making both optional would be great.

Thanks,
Nícolas