Re: [PATCH] Fix le16_to_cpu warning for beacon_interval

[Kalle Valo]

Srinivasan Raju <srini.raju@xxxxxxxxxxxx> writes:

> Fixed the following warning
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]

The preferred style is this:

Fix the following sparse warnings:

drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]

> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Srinivasan Raju <srini.raju@xxxxxxxxxxxx>
> ---
>  drivers/net/wireless/purelifi/plfxlc/chip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

The subject should be:

[PATCH] plfxlc: fix le16_to_cpu warning for beacon_interval

> diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c
> index a5ec10b66ed5..5d952ca07195 100644
> --- a/drivers/net/wireless/purelifi/plfxlc/chip.c
> +++ b/drivers/net/wireless/purelifi/plfxlc/chip.c
> @@ -30,10 +30,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval,
>  {
>         if (!interval ||
>             (chip->beacon_set && 
> -            le16_to_cpu(chip->beacon_interval) == interval))
> +            chip->beacon_interval) == interval)
>                 return 0;

I think there's no need to use three lines anymore, two lines should be
enough:

       if (!interval ||
           (chip->beacon_set && chip->beacon_interval == interval))

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches