Re: [PATCH 1/2] irqchip/armada-370-xp: Do not touch Performance Counter Overflow on A375, A38x, A39x

From: Pali Rohár
Date: Fri Apr 29 2022 - 09:06:01 EST


On Friday 29 April 2022 14:23:08 Andrew Lunn wrote:
> On Mon, Apr 25, 2022 at 01:37:05PM +0200, Pali Rohár wrote:
> > Register ARMADA_370_XP_INT_FABRIC_MASK_OFFS is Armada 370 and XP specific
> > and on new Armada platforms it has different meaning. It does not configure
> > Performance Counter Overflow interrupt masking. So do not touch this
> > register on non-A370/XP platforms (A375, A38x and A39x).
>
> Hi Pali
>
> Do the Armada 375, 38x and 39x have an over flow interrupt? I assume
> not.

Hello! According to documentation there is something named performance
counter interrupt, but it is in different register... and this register
is not per-cpu.

> Does this need a fixes tag? Should it be back ported in stable?

git blame show that this functionality appeared in commit 28da06dfd9e4
("irqchip: armada-370-xp: Enable the PMU interrupts").