Re: [PATCH 1/3] KVM: x86: make vendor code check for all nested events

From: Paolo Bonzini
Date: Fri Apr 29 2022 - 13:09:19 EST


On 4/29/22 19:03, Sean Christopherson wrote:
This doesn't even compile...

arch/x86/kvm/vmx/nested.c: In function ‘vmx_has_nested_events’:
arch/x86/kvm/vmx/nested.c:3862:61: error: ‘vmx’ undeclared (first use in this function)
3862 | return nested_vmx_preemption_timer_pending(vcpu) || vmx->nested.mtf_pending;
| ^~~
arch/x86/kvm/vmx/nested.c:3862:61: note: each undeclared identifier is reported only once for each function it appears in
CC [M] arch/x86/kvm/svm/svm_onhyperv.o
arch/x86/kvm/vmx/nested.c:3863:1: error: control reaches end of non-void function [-Werror=return-type]
3863 | }
| ^
cc1: all warnings being treated as errors
LD [M] arch/x86/kvm/kvm.o

Yeah, it doesn't. Of course this will need a v2, also because there are failures in the vmx tests.

What can I say, testing these patches on AMD hardware wasn't a great idea.

Paolo