Re: [PATCH 1/5] dt-bindings: thermal: tsens: Add ipq8074 compatible

[Krzysztof Kozlowski]

On 30/04/2022 22:50, Robert Marko wrote:
> Qualcomm IPQ8074 has tsens v2.3.0 block, though unlike existing v2 IP it
> only uses one IRQ, so tsens v2 compatible cannot be used as the fallback.
> 
> We also have to make sure that correct interrupts are set according to
> compatibles, so populate interrupt information per compatibles.
> 
> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
> ---
>  .../bindings/thermal/qcom-tsens.yaml          | 79 ++++++++++++++++---
>  1 file changed, 68 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index b6406bcc683f..44ebdfd4560a 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -56,22 +56,19 @@ properties:
>                - qcom,sm8350-tsens
>            - const: qcom,tsens-v2
>  
> +      - description: v2 of TSENS with combined interrupt
> +        items:

It's just an enum, no list here.

> +          - enum:
> +              - qcom,ipq8074-tsens
> +
>    reg:
>      items:
>        - description: TM registers
>        - description: SROT registers
>  
> -  interrupts:
> -    minItems: 1
> -    items:
> -      - description: Combined interrupt if upper or lower threshold crossed
> -      - description: Interrupt if critical threshold crossed
> +  interrupts: true

minItems: 1
maxItems: 2

>  
> -  interrupt-names:
> -    minItems: 1
> -    items:
> -      - const: uplow
> -      - const: critical
> +  interrupt-names: true

minItems: 1
maxItems: 2


Best regards,
Krzysztof