Re: [RFC v2 13/39] iio: adc: Kconfig: add HAS_IOPORT dependencies

[Jonathan Cameron]

On Fri, 29 Apr 2022 15:50:20 +0200
Niklas Schnelle <schnelle@xxxxxxxxxxxxx> wrote:

> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.
> 
> Co-developed-by: Arnd Bergmann <arnd@xxxxxxxxxx>
> Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>

Hi.

Please call out specific driver as that'll increase chance
of relevant people noticing (there are quite a lot of ADC drivers!)

e.g.
iio: adc: ad7606: ....

Anyhow, looks fine to me

Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Thanks,


> ---
>  drivers/iio/adc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 71ab0a06aa82..c99843307e4f 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -130,7 +130,7 @@ config AD7606
>  
>  config AD7606_IFACE_PARALLEL
>  	tristate "Analog Devices AD7606 ADC driver with parallel interface support"
> -	depends on HAS_IOMEM
> +	depends on HAS_IOPORT
>  	select AD7606
>  	help
>  	  Say yes here to build parallel interface support for Analog Devices: