Re: [PATCH 3/3] PCI: apple: Add support for optional PWREN GPIO

From: Hector Martin
Date: Mon May 02 2022 - 08:16:19 EST


On 02/05/2022 19.31, Marc Zyngier wrote:
> On Mon, 02 May 2022 10:38:32 +0100,
> Hector Martin <marcan@xxxxxxxxx> wrote:
>>
>> WiFi and SD card devices on M1 Macs have a separate power enable GPIO.
>> Add support for this to the PCIe controller. This is modeled after how
>> pcie-fu740 does it.
>
> Please update the DT binding to reflect this as an optional property.

That's a bit more involved than you might think, considering we aren't
checking *any* properties in the root port child nodes right now :-)

How's this?

patternProperties:
"^pci@":
$ref: /schemas/pci/pci-bus.yaml#
type: object
description: A single PCI root port

properties:
reg:
maxItems: 1

pwren-gpios:
description: Optional GPIO to power on the device
maxItems: 1

required:
- reset-gpios
- interrupt-controller
- "#interrupt-cells"
- interrupt-map-mask
- interrupt-map

--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub