Re: [PATCH v2 4/4] ARM: dts: qcom: sdx65-mtp: Enable QPIC NAND support

[Manivannan Sadhasivam]

On Mon, May 02, 2022 at 07:14:38AM -0700, Kaushal Kumar wrote:
> Enable QPIC NAND devicetree node for Qualcomm SDX65-MTP board.
> 
> Signed-off-by: Kaushal Kumar <quic_kaushalk@xxxxxxxxxxx>

One comment below, with that fixed:

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

> ---
>  arch/arm/boot/dts/qcom-sdx65-mtp.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> index 153ad2a..b0027c1 100644
> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> @@ -249,6 +249,21 @@
>  	status = "ok";
>  };
>  
> +&qpic_nand {
> +	status = "ok";
> +

Status should be "okay".

Thanks,
Mani

> +	nand@0 {
> +		reg = <0>;
> +
> +		nand-ecc-strength = <4>;
> +		nand-ecc-step-size = <512>;
> +		nand-bus-width = <8>;
> +		/* ico and efs2 partitions are secured */
> +		secure-regions = /bits/ 64 <0x500000 0x500000
> +					    0xa00000 0xb00000>;
> +	};
> +};
> +
>  &usb {
>  	status = "okay";
>  };
> -- 
> 2.7.4
>