Re: [PATCH v5 1/3] x86/tdx: Add TDX Guest attestation interface driver

From: Sathyanarayanan Kuppuswamy
Date: Mon May 02 2022 - 12:06:59 EST




On 5/2/22 5:18 AM, Wander Lairson Costa wrote:
+ ret = __tdx_module_call(TDX_GET_REPORT, virt_to_phys(tdreport),
+ virt_to_phys(reportdata), 0, 0, NULL);
+ if (ret) {
+ pr_debug("TDREPORT TDCALL failed, status:%lx\n",
+ TDCALL_STATUS_CODE(ret));
Should we use pr_err instead?

I expect user app will handle this error case and print debug info.
So we don't need to use pr_err.

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer