Re: [PATCH v2 1/3] of: overlay: add entry to of_overlay_action_name[]

From: Rob Herring
Date: Mon May 02 2022 - 21:11:53 EST


On Mon, 02 May 2022 13:17:40 -0500, frowand.list@xxxxxxxxx wrote:
> From: Frank Rowand <frank.rowand@xxxxxxxx>
>
> The values of enum of_overlay_notify_action are used to index into
> array of_overlay_action_name. Add an entry to of_overlay_action_name
> for the value recently added to of_overlay_notify_action.
>
> Array of_overlay_action_name[] is moved into include/linux/of.h
> adjacent to enum of_overlay_notify_action to make the connection
> between the two more obvious if either is modified in the future.
>
> The only use of of_overlay_action_name is for error reporting in
> overlay_notify(). All callers of overlay_notify() report the same
> error, but with fewer details. Remove the redundant error reports
> in the callers.
>
> Fixes: 067c098766c6 ("of: overlay: rework overlay apply and remove kfree()s")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
> ---
> Changes since version 1:
> - patch 1/1 v1 did not apply on Rob's dt/next branch, rebase on top of
> 5f756a2eaa44 of: overlay: do not break notify on NOTIFY_{OK|STOP}
>
> drivers/of/overlay.c | 27 +++++----------------------
> include/linux/of.h | 13 +++++++++++++
> 2 files changed, 18 insertions(+), 22 deletions(-)
>

Applied, thanks!