drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
From: kernel test robot
Date: Mon May 02 2022 - 23:39:31 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9050ba3a61a4b5bd84c2cde092a100404f814f31
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 11 months ago
config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/archive/20220503/202205031153.oyQ1vVL3-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1909 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
--
0-DAY CI Kernel Test Service
https://01.org/lkp