Re: [PATCH v8 2/2] dt-bindings:thermal: Add Sunplus schema
From: Krzysztof Kozlowski
Date: Tue May 03 2022 - 05:00:41 EST
On 03/05/2022 04:13, Li-hao Kuo wrote:
> Add bindings for Sunplus thermal driver
>
> Signed-off-by: Li-hao Kuo <lhjeff911@xxxxxxxxx>
> ---
> Changes in v8:
> - Modify yaml file.
> modify the setting compatible
> - Change yaml file name.
> - Modify driver.
> mosdify and simply the nvmem setting and remove valiable
>
> .../bindings/thermal/sunplus,thermal.yaml | 43 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
> new file mode 100644
> index 0000000..1ecf6f6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/sunplus,thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus Thermal controller
> +
> +maintainers:
> + - Li-hao Kuo <lhjeff911@xxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - sunplus,thermal
This is a very surprising change and was never requested by me or other
reviewers. It is also not correct. Previous compatible was correct.
Best regards,
Krzysztof