Re: [PATCH v7 00/36] MT8195 and MT8186 IOMMU SUPPORT
From: Matthias Brugger
Date: Tue May 03 2022 - 11:42:58 EST
On 03/05/2022 09:13, Yong Wu wrote:
This patchset adds MT8195 and MT8186 iommu support.
MT8195 have 3 IOMMU HWs. 2 IOMMU HW is for multimedia, and 1 IOMMU HW is
for infra-master, like PCIe/USB.
About the 2 MM IOMMU HW, something like this:
IOMMU(VDO) IOMMU(VPP)
| |
SMI_COMMON(VDO) SMI_COMMON(VPP)
--------------- ----------------
| | ... | | ...
larb0 larb2 ... larb1 larb3 ...
these two MM IOMMU HW share a pgtable.
About the INFRA IOMMU, it don't have larbs, the master connects the iommu
directly. It use a independent pgtable.
Also, mt8195 IOMMU bank supports. Normally the IOMMU register size only
is 0x1000. In this IOMMU HW, the register size is 5 * 0x1000. each 0x1000
is a bank. the banks' register look like this:
----------------------------------------
|bank0 | bank1 | bank2 | bank3 | bank4|
----------------------------------------
|global |
|control| null
|regs |
-----------------------------------------
|bank |bank |bank |bank |bank |
|regs |regs |regs |regs |regs |
| | | | | |
-----------------------------------------
All the banks share some global control registers, and each bank have its
special bank registers, like pgtable base register, tlb operation registers,
the fault status registers.
In mt8195, we enable this bank feature for infra iommu, We put PCIe in bank0
and USB in bank4. they have independent pgtable.
MT8186 is based on MT8195, it just has two patches.
Change note:
v7: 1) Update the changes from Matthias. like add a new function for readability.
2) Add mt8186 into this patchset, It may be helpful for maintainer to apply.
For the whole series:
Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
v6: https://lore.kernel.org/linux-iommu/20220407075726.17771-1-yong.wu@xxxxxxxxxxxx/
Rebase on v5.18-rc1.
v5: https://lore.kernel.org/linux-iommu/20220217113453.13658-1-yong.wu@xxxxxxxxxxxx
1) Base on next-20220216
2) Remove a patch for kmalloc for protect buffer. keep the kzalloc for it.
3) minor fix from AngeloGioacchino, like rename the error label name
(data_unlock to err_unlock).
Note, keep the TODO for component compare_of[26/34].
v4: https://lore.kernel.org/linux-iommu/20220125085634.17972-1-yong.wu@xxxxxxxxxxxx/
1) Base on v5.16-rc1
2) Base on tlb logic 2 patchset, some patches in v3 has already gone
through that patchset.
3) Due to the unreadable union for v1/v2(comment in 26/33 of v3), I
separate mtk_iommu_data for v1 and v2 totally, then remove mtk_iommu.h.
please see patch[26/35][27/35].
4) add two mutex for the internal data. patch[6/35][7/35].
5) add a new flag PM_CLK_AO.
v3: https://lore.kernel.org/linux-mediatek/20210923115840.17813-1-yong.wu@xxxxxxxxxxxx/
1) base on v5.15-rc1
2) Adjust devlink with smi-common, not use the property(sub-sommon).
3) Adjust tlb_flush_all flow,
a) Fix tlb_flush_all only is supported in bank0.
b) add tlb-flush-all in the resume callback.
c) remove the pm status checking in tlb-flush-all.
The reason are showed in the commit message.
4) Allow IOMMU_DOMAIN_UNMANAGED since PCIe VFIO use that.
5) Fix a clk warning and a null abort when unbind the iommu driver.
v2: https://lore.kernel.org/linux-mediatek/20210813065324.29220-1-yong.wu@xxxxxxxxxxxx/
1) Base on v5.14-rc1.
2) Fix build fail for arm32.
3) Fix dt-binding issue from Rob.
4) Fix the bank issue when tlb flush. v1 always use bank->base.
5) adjust devlink with smi-common since the node may be smi-sub-common.
6) other changes: like reword some commit message(removing many
"This patch..."); seperate serveral patches.
v1: https://lore.kernel.org/linux-mediatek/20210630023504.18177-1-yong.wu@xxxxxxxxxxxx/
Base on v5.13-rc1
Yong Wu (36):
dt-bindings: mediatek: mt8195: Add binding for MM IOMMU
dt-bindings: mediatek: mt8195: Add binding for infra IOMMU
dt-bindings: mediatek: mt8186: Add binding for MM iommu
iommu/mediatek: Fix 2 HW sharing pgtable issue
iommu/mediatek: Add list_del in mtk_iommu_remove
iommu/mediatek: Remove clk_disable in mtk_iommu_remove
iommu/mediatek: Add mutex for m4u_group and m4u_dom in data
iommu/mediatek: Add mutex for data in the mtk_iommu_domain
iommu/mediatek: Adapt sharing and non-sharing pgtable case
iommu/mediatek: Add 12G~16G support for multi domains
iommu/mediatek: Add a flag DCM_DISABLE
iommu/mediatek: Add a flag STD_AXI_MODE
iommu/mediatek: Remove the granule in the tlb flush
iommu/mediatek: Always enable output PA over 32bits in isr
iommu/mediatek: Add SUB_COMMON_3BITS flag
iommu/mediatek: Add IOMMU_TYPE flag
iommu/mediatek: Contain MM IOMMU flow with the MM TYPE
iommu/mediatek: Adjust device link when it is sub-common
iommu/mediatek: Allow IOMMU_DOMAIN_UNMANAGED for PCIe VFIO
iommu/mediatek: Add a PM_CLK_AO flag for infra iommu
iommu/mediatek: Add infra iommu support
iommu/mediatek: Add PCIe support
iommu/mediatek: Add mt8195 support
iommu/mediatek: Only adjust code about register base
iommu/mediatek: Just move code position in hw_init
iommu/mediatek: Separate mtk_iommu_data for v1 and v2
iommu/mediatek: Remove mtk_iommu.h
iommu/mediatek-v1: Just rename mtk_iommu to mtk_iommu_v1
iommu/mediatek: Add mtk_iommu_bank_data structure
iommu/mediatek: Initialise bank HW for each a bank
iommu/mediatek: Change the domid to iova_region_id
iommu/mediatek: Get the proper bankid for multi banks
iommu/mediatek: Initialise/Remove for multi bank dev
iommu/mediatek: Backup/restore regsiters for multi banks
iommu/mediatek: mt8195: Enable multi banks for infra iommu
iommu/mediatek: Add mt8186 iommu support
.../bindings/iommu/mediatek,iommu.yaml | 24 +-
drivers/iommu/mtk_iommu.c | 974 +++++++++++++-----
drivers/iommu/mtk_iommu.h | 101 --
drivers/iommu/mtk_iommu_v1.c | 235 +++--
.../dt-bindings/memory/mt8186-memory-port.h | 217 ++++
.../dt-bindings/memory/mt8195-memory-port.h | 408 ++++++++
include/dt-bindings/memory/mtk-memory-port.h | 2 +
7 files changed, 1485 insertions(+), 476 deletions(-)
delete mode 100644 drivers/iommu/mtk_iommu.h
create mode 100644 include/dt-bindings/memory/mt8186-memory-port.h
create mode 100644 include/dt-bindings/memory/mt8195-memory-port.h