Re: [PATCH net-next] net/core: Remove comment quote for __dev_queue_xmit()

[Jakub Kicinski]

On Tue,  3 May 2022 14:29:49 +0700 Bagas Sanjaya wrote:
> - * -----------------------------------------------------------------------------------
> - *      I notice this method can also return errors from the queue disciplines,
> - *      including NET_XMIT_DROP, which is a positive value.  So, errors can also
> - *      be positive.
> - *
> - *      Regardless of the return value, the skb is consumed, so it is currently
> - *      difficult to retry a send to this method.  (You can bump the ref count
> - *      before sending to hold a reference for retry if you are careful.)
> - *
> - *      When calling this method, interrupts MUST be enabled.  This is because
> - *      the BH enable code must have IRQs enabled so that it will not deadlock.
> - *          --BLG
> + *	This method can also return positive errno code from the queue
> + *	disciplines (including NET_XMIT_DROP).
> + *
> + *	Note that regardless of the return value, the skb is consumed
> + *	anyway, so it is currently difficult to retry sending to this
> + *	method.

Why drop almost half of the comment if the problem is just the ----
banner?