[irqchip: irq/irqchip-next] irqchip/aspeed-i2c-ic: Fix irq_of_parse_and_map() return value
From: irqchip-bot for Krzysztof Kozlowski
Date: Wed May 04 2022 - 12:15:50 EST
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 50f0f26e7c8665763d0d7d3372dbcf191f94d077
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/50f0f26e7c8665763d0d7d3372dbcf191f94d077
Author: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
AuthorDate: Sat, 23 Apr 2022 11:42:26 +02:00
Committer: Marc Zyngier <maz@xxxxxxxxxx>
CommitterDate: Wed, 04 May 2022 16:37:48 +01:00
irqchip/aspeed-i2c-ic: Fix irq_of_parse_and_map() return value
The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
Fixes: f48e699ddf70 ("irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20220423094227.33148-1-krzysztof.kozlowski@xxxxxxxxxx
---
drivers/irqchip/irq-aspeed-i2c-ic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-aspeed-i2c-ic.c b/drivers/irqchip/irq-aspeed-i2c-ic.c
index a47db16..9c9fc3e 100644
--- a/drivers/irqchip/irq-aspeed-i2c-ic.c
+++ b/drivers/irqchip/irq-aspeed-i2c-ic.c
@@ -77,8 +77,8 @@ static int __init aspeed_i2c_ic_of_init(struct device_node *node,
}
i2c_ic->parent_irq = irq_of_parse_and_map(node, 0);
- if (i2c_ic->parent_irq < 0) {
- ret = i2c_ic->parent_irq;
+ if (!i2c_ic->parent_irq) {
+ ret = -EINVAL;
goto err_iounmap;
}