[irqchip: irq/irqchip-next] irqchip/gic: Improved warning about incorrect type

[irqchip-bot for Florian Fainelli]

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     4c5b2be1d071af26749790429726712e4d9105fb
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/4c5b2be1d071af26749790429726712e4d9105fb
Author:        Florian Fainelli <f.fainelli@xxxxxxxxx>
AuthorDate:    Tue, 08 Mar 2022 12:11:16 -08:00
Committer:     Marc Zyngier <maz@xxxxxxxxxx>
CommitterDate: Wed, 04 May 2022 16:52:28 +01:00

irqchip/gic: Improved warning about incorrect type

Issue the warning for interrupt lines that have an incorrect interrupt
type and also print the hardware interrupt number to facilitate the
resolution of such problems.

Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20220308201117.3870678-1-f.fainelli@xxxxxxxxx
---
 drivers/irqchip/irq-gic.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 09c710e..820404c 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -1115,7 +1115,8 @@ static int gic_irq_domain_translate(struct irq_domain *d,
 		*type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
 
 		/* Make it clear that broken DTs are... broken */
-		WARN_ON(*type == IRQ_TYPE_NONE);
+		WARN(*type == IRQ_TYPE_NONE,
+		     "HW irq %ld has invalid type\n", *hwirq);
 		return 0;
 	}
 
@@ -1132,7 +1133,8 @@ static int gic_irq_domain_translate(struct irq_domain *d,
 		*hwirq = fwspec->param[0];
 		*type = fwspec->param[1];
 
-		WARN_ON(*type == IRQ_TYPE_NONE);
+		WARN(*type == IRQ_TYPE_NONE,
+		     "HW irq %ld has invalid type\n", *hwirq);
 		return 0;
 	}