Re: [PATCH] gpiolib: cdev: fix stream_open.cocci warnings
From: Bartosz Golaszewski
Date: Thu May 05 2022 - 08:19:05 EST
On Thu, May 5, 2022 at 1:50 PM Yihao Han <hanyihao@xxxxxxxx> wrote:
>
> ./drivers/gpio/gpiolib-cdev.c:2498:7-23: WARNING:
> gpio_fileops: .read() has stream semantic;
> safe to change nonseekable_open -> stream_open.
>
> Generated by: scripts/coccinelle/api/stream_open.cocci
>
> Signed-off-by: Yihao Han <hanyihao@xxxxxxxx>
> ---
> drivers/gpio/gpiolib-cdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index f5aa5f93342a..d03c8e012c8c 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -2495,7 +2495,7 @@ static int gpio_chrdev_open(struct inode *inode, struct file *file)
> get_device(&gdev->dev);
> file->private_data = cdev;
>
> - ret = nonseekable_open(inode, file);
> + ret = stream_open(inode, file);
> if (ret)
> goto out_unregister_notifier;
>
> --
> 2.17.1
>
Cc'ing Kent.
This patch doesn't seem to target current master or rc1.
It also can't be right - we specifically mark all filesystem objects
exposed by the GPIO character device as non-seekable.
Bart