Re: [PATCH] device property: Fix recent breakage of fwnode_get_next_parent_dev()

[Rafael J. Wysocki]

On Sun, May 1, 2022 at 9:50 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Sat, Apr 30, 2022 at 3:00 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> >
> > Due to a subtle typo, instead of commit 87ffea09470d ("device
> > property: Introduce fwnode_for_each_parent_node()") being a no-op
> > change, it ended up causing the display on my sc7180-trogdor-lazor
> > device from coming up unless I added "fw_devlink=off" to my kernel
> > command line. Fix the typo.
>
> Sorry and merci pour la fix!
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Applied, thanks!

> > Fixes: 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()")
> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > ---
> >
> >  drivers/base/property.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > index 36401cfe432c..52e85dcb20b5 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -600,7 +600,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode)
> >         struct device *dev;
> >
> >         fwnode_for_each_parent_node(fwnode, parent) {
> > -               dev = get_dev_from_fwnode(fwnode);
> > +               dev = get_dev_from_fwnode(parent);
> >                 if (dev) {
> >                         fwnode_handle_put(parent);
> >                         return dev;
> > --
> > 2.36.0.464.gb9c8b46e94-goog
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko