Re: [PATCH] ACPI: DPTF: Add support for high frequency impedance notification

[srinivas pandruvada]

On Wed, 2022-04-27 at 21:21 +0530, Sumeet Pawnikar wrote:
> Add high frequency impedance notification support under DPTF.
> This returns high frequency impedance value that can be obtained
> from battery fuel gauge whenever there is change over a threshold.
> 
I think you should add
While here corrected spelling from IMPEDANCED_CHNGED to
IMPEDANCE_CHANGED.

Otherwise looks good to me.

Thanks,
Srinivas

> Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@xxxxxxxxx>
> ---
>  drivers/acpi/dptf/dptf_power.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/dptf/dptf_power.c
> b/drivers/acpi/dptf/dptf_power.c
> index dc1f52a5b3f4..2ef53ca88714 100644
> --- a/drivers/acpi/dptf/dptf_power.c
> +++ b/drivers/acpi/dptf/dptf_power.c
> @@ -117,7 +117,7 @@ static const struct attribute_group
> dptf_battery_attribute_group = {
>  #define POWER_STATE_CHANGED            0x81
>  #define STEADY_STATE_POWER_CHANGED     0x83
>  #define POWER_PROP_CHANGE_EVENT        0x84
> -#define IMPEDANCED_CHNGED              0x85
> +#define IMPEDANCE_CHANGED              0x85
>  #define VOLTAGE_CURRENT_CHANGED        0x86
>  
>  static long long dptf_participant_type(acpi_handle handle)
> @@ -150,6 +150,9 @@ static void dptf_power_notify(acpi_handle handle,
> u32 event, void *data)
>         case STEADY_STATE_POWER_CHANGED:
>                 attr = "max_steady_state_power_mw";
>                 break;
> +       case IMPEDANCE_CHANGED:
> +               attr = "high_freq_impedance_mohm";
> +               break;
>         case VOLTAGE_CURRENT_CHANGED:
>                 attr = "no_load_voltage_mv";
>                 break;