Re: [PATCH] ARM: at91: Kconfig: implement PIT64B selection

[Nicolas Ferre]

On 09/03/2022 at 11:08, Claudiu Beznea wrote:
> Implement PIT64B selection thus it will be available for the necessary
> targets (at the moment SAM9X60 and SAMA7G5) w/o the necessity to
> specify it via defconfig. With this the current CONFIG_TIMER_OF
> dependency of PIT64B driver could be removed. Along with changes
> on AT91 Kconfig removed CONFIG_MICROCHIP_PIT64B from defconfigs.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> ---
>   arch/arm/configs/at91_dt_defconfig  | 1 -
>   arch/arm/configs/multi_v7_defconfig | 1 -
>   arch/arm/configs/sama7_defconfig    | 1 -
>   arch/arm/mach-at91/Kconfig          | 9 +++++++++

Hi Claudiu,

To match arm-soc flow, this probably would need to be spit in 2 patches: 
one for the Kconfig changes. Then, when it's integrated, we shall queue 
the other defconfig changes (having them around even with the Kconfig 
change doesn't harm).

I let you do this change. Best regards,
  Nicolas

>   4 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
> index 549d01be0b47..04f71dac9c97 100644
> --- a/arch/arm/configs/at91_dt_defconfig
> +++ b/arch/arm/configs/at91_dt_defconfig
> @@ -195,7 +195,6 @@ CONFIG_RTC_DRV_AT91SAM9=y
>   CONFIG_DMADEVICES=y
>   CONFIG_AT_HDMAC=y
>   CONFIG_AT_XDMAC=y
> -CONFIG_MICROCHIP_PIT64B=y
>   # CONFIG_IOMMU_SUPPORT is not set
>   CONFIG_IIO=y
>   CONFIG_AT91_ADC=y
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 8863fa969ede..bec62d5aa3c6 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -989,7 +989,6 @@ CONFIG_APQ_MMCC_8084=y
>   CONFIG_MSM_GCC_8660=y
>   CONFIG_MSM_MMCC_8960=y
>   CONFIG_MSM_MMCC_8974=y
> -CONFIG_MICROCHIP_PIT64B=y
>   CONFIG_BCM2835_MBOX=y
>   CONFIG_ROCKCHIP_IOMMU=y
>   CONFIG_TEGRA_IOMMU_GART=y
> diff --git a/arch/arm/configs/sama7_defconfig b/arch/arm/configs/sama7_defconfig
> index 07b0494ef743..2b0f020a18eb 100644
> --- a/arch/arm/configs/sama7_defconfig
> +++ b/arch/arm/configs/sama7_defconfig
> @@ -182,7 +182,6 @@ CONFIG_RTC_DRV_AT91SAM9=y
>   CONFIG_DMADEVICES=y
>   CONFIG_AT_XDMAC=y
>   CONFIG_STAGING=y
> -CONFIG_MICROCHIP_PIT64B=y
>   # CONFIG_IOMMU_SUPPORT is not set
>   CONFIG_IIO=y
>   CONFIG_IIO_SW_TRIGGER=y
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 279810381256..1531b4625c76 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -165,6 +165,15 @@ config ATMEL_CLOCKSOURCE_TCB
>   	  to make a single 32-bit timer.
>   	  It can also be used as a clock event device supporting oneshot mode.
>   
> +config MICROCHIP_CLOCKSOURCE_PIT64B
> +	bool "64-bit Periodic Interval Timer (PIT64B) support"
> +	default SOC_SAM9X60 || SOC_SAMA7
> +	select MICROCHIP_PIT64B
> +	help
> +	  Select this to get a high resolution clockevent (SAM9X60) or
> +	  clocksource and clockevent (SAMA7G5) based on Microchip 64-bit
> +	  Periodic Interval Timer.
> +
>   config HAVE_AT91_UTMI
>   	bool
>   


--
Nicolas Ferre