Re: [PATCH v5 2/6] perf evlist: Clear all_cpus before propagating

[Arnaldo Carvalho de Melo]

Em Wed, May 04, 2022 at 05:15:57PM +0300, Adrian Hunter escreveu:
> On 3/05/22 07:17, Ian Rogers wrote:
> > all_cpus is merged into during propagation. Initially all_cpus is set
> > from PMU sysfs. perf_evlist__set_maps will recompute it and change
> > evsel->cpus to user_requested_cpus if they are given. If all_cpus isn't
> > cleared then the union of the user_requested_cpus and PMU sysfs values
> > is set to all_cpus, whereas just user_requested_cpus is necessary. To
> > avoid this make all_cpus empty prior to propagation.
> > 
> > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> 
> Reviewed-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

Thanks, applied.

- Arnaldo

 
> > ---
> >  tools/lib/perf/evlist.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c
> > index a09315538a30..974b4585f93e 100644
> > --- a/tools/lib/perf/evlist.c
> > +++ b/tools/lib/perf/evlist.c
> > @@ -59,6 +59,10 @@ static void perf_evlist__propagate_maps(struct perf_evlist *evlist)
> >  {
> >  	struct perf_evsel *evsel;
> >  
> > +	/* Recomputing all_cpus, so start with a blank slate. */
> > +	perf_cpu_map__put(evlist->all_cpus);
> > +	evlist->all_cpus = NULL;
> > +
> >  	perf_evlist__for_each_evsel(evlist, evsel)
> >  		__perf_evlist__propagate_maps(evlist, evsel);
> >  }

-- 

- Arnaldo