Re: [PATCH v2 3/3] x86: Fix comment for X86_FEATURE_ZEN

[Wyes Karny]

Hello Dave,

On 5/5/2022 10:40 PM, Dave Hansen wrote:
> On 5/5/22 04:04, Wyes Karny wrote:
>> The feature X86_FEATURE_ZEN implies that the CPU supports Zen
>> microarchitecture. Call this out explicitly in the comment.
> 
> Is "supports" the best word here?
> 
> A CPU is based on a microarchitecture, it doesn't really support it.  I
> guess we could say the CPU supports a microarchitecture's *features*,
> but that's a bit wordy for a tiny comment.
> 
> Maybe:
> 
> #define X86_FEATURE_ZEN			(7*32+28) /* "" CPU based on Zen uarch */

Thank you, Dave. Yes, "based on" could be a better choice here. I'll update this.

> 
> or spell out "microarchitecture" if there's room.

Thanks,
Wyes