Re: time.c:undefined reference to `mach_get_rtc_pll'

[Arnd Bergmann]

On Wed, May 4, 2022 at 3:33 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Wed, May 4, 2022 at 2:25 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > On Wed, May 4, 2022 at 11:14 AM kernel test robot <lkp@xxxxxxxxx> wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   107c948d1d3e61d10aee9d0f7c3d81bbee9842af
> > > commit: 8b22820efb35f93d98638563b0a8f4094e8ee399 m68k: m68328: remove duplicate code
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >    m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl':
> > > >> time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll'
> > >    m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll'
> > >    m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll'
> > >
> >
> > I think this is just another build failure that was hidden before my patch,
> > not caused by my patch.
>
> That's an m68knommu kernel build with CONFIG_RTC_DRV_GENERIC=y,
> I guess?

Correct, the  .config file is linked in the original report, just double-checked
that. More importantly, it's a nommu M68KCLASSIC (dragonball) config,
so the existing #ifdef CONFIG_M68KCLASSIC check in
arch/m68k/kernel/time.c is insufficient.

       Arnd