Re: [PATCH] ssb: remove unreachable code

[Michael Büsch]

On Fri,  6 May 2022 15:58:14 +0800
Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:

> Clean up the following smatch warning:
> 
> drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable
> code.
> 
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/ssb/pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index 148bcb99c212..493bebbba521 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -914,7 +914,6 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
>  				err = 0;
>  				goto out_free;
>  			}
> -			pr_warn("WARNING: Invalid SPROM CRC (corrupt
> SPROM)\n"); }
>  	}
>  	err = sprom_extract(bus, sprom, buf, bus->sprom_size);



Acked-by: Michael Büsch <m@xxxxxxx>

-- 
Michael Büsch
https://bues.ch/

Attachment: pgpWTehRlG5nJ.pgp
Description: OpenPGP digital signature