Re: [linuxppc:next-test 75/91] arch/powerpc/kernel/prom_parse.c:10:6: warning: no previous prototype for 'of_parse_dma_window'

From: Michael Ellerman
Date: Sun May 08 2022 - 08:17:06 EST


Christophe Leroy <christophe.leroy@xxxxxxxxxx> writes:
> Le 06/05/2022 à 05:46, kernel test robot a écrit :
>> tree: https://github.com/linuxppc/linux next-test
>> head: 1d8abffc14aef88bfe1ad036084070af62f30c03
>> commit: 34fa52eec206db38399dc9b54f2da2eed4fdad5e [75/91] powerpc: Remove asm/prom.h from all files that don't need it
>> config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220506/202205061138.zH9VucCL-lkp@xxxxxxxxx/config)
>> compiler: powerpc-linux-gcc (GCC) 11.3.0
>> reproduce (this is a W=1 build):
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # https://github.com/linuxppc/linux/commit/34fa52eec206db38399dc9b54f2da2eed4fdad5e
>> git remote add linuxppc https://github.com/linuxppc/linux
>> git fetch --no-tags linuxppc next-test
>> git checkout 34fa52eec206db38399dc9b54f2da2eed4fdad5e
>> # save the config file
>> mkdir build_dir && cp config build_dir/.config
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> arch/powerpc/kernel/prom_parse.c:10:6: warning: no previous prototype for 'of_parse_dma_window' [-Wmissing-prototypes]
>> 10 | void of_parse_dma_window(struct device_node *dn, const __be32 *dma_window,
>> | ^~~~~~~~~~~~~~~~~~~
>>
>>
>
> Ok, so asm/prom.h must remain in arch/powerpc/kernel/prom_parse.c to get
> of_parse_dma_window() prototype.
>
> Michael, can you drop the hunk when applying ?

Yep, done.

cheers