[PATCH] tracing: Fix possible crash in ftrace_free_ftrace_ops()

From: Jeff Xie
Date: Sun May 08 2022 - 12:19:03 EST


Currently if the ftrace_allocate_ftrace_ops() return -ENOMEM,
the ftrace_free_ftrace_ops() will kfree(NULL).

trace_array_create()
{
...
if (ftrace_allocate_ftrace_ops(tr) < 0)
goto out_free_tr;
...
out_free_tr:
ftrace_free_ftrace_ops(tr);
...
}

ftrace_allocate_ftrace_ops()
{
...
ops = kzalloc(sizeof(*ops), GFP_KERNEL);
if (!ops)
return -ENOMEM;
...
}

ftrace_free_ftrace_ops()
{
kfree(tr->ops);
tr->ops = NULL;
}

Signed-off-by: Jeff Xie <xiehuan09@xxxxxxxxx>
---
kernel/trace/trace_functions.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c
index 9f1bfbe105e8..d186d6101695 100644
--- a/kernel/trace/trace_functions.c
+++ b/kernel/trace/trace_functions.c
@@ -73,6 +73,9 @@ int ftrace_allocate_ftrace_ops(struct trace_array *tr)

void ftrace_free_ftrace_ops(struct trace_array *tr)
{
+ if (!tr->ops)
+ return;
+
kfree(tr->ops);
tr->ops = NULL;
}
--
2.25.1