Re: [PATCH v2] pcmcia: add MIPS_DB1XXX dependence

From: Arnd Bergmann
Date: Mon May 09 2022 - 03:27:11 EST


On Mon, May 9, 2022 at 4:02 AM Stephen Zhang <starzhangzsd@xxxxxxxxx> wrote:
>
> From: Shida Zhang <zhangshida@xxxxxxxxxx>
>
> drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from
> arch/mips/alchemy/devboards/bcsr.c, which causes a link
> error:
>
> drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_read'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to `bcsr_read'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mod'
>
>
> So add MIPS_DB1XXX dependence.
>
> Signed-off-by: Shida Zhang <zhangshida@xxxxxxxxxx>
> ---

Looks good to me,

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>