Re: [PATCH v2 01/14] thermal/core: Change thermal_zone_ops to thermal_sensor_ops

From: Geert Uytterhoeven
Date: Mon May 09 2022 - 05:34:08 EST


Hi Daniel,

Thanks for your patch!

On Sat, May 7, 2022 at 3:03 PM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
> A thermal zone is software abstraction of a sensor associated with
> properties and cooling devices if any.
>
> The fact that we have thermal_zone and thermal_zone_ops mixed is
> confusing and does not clearly identify the different components
> entering in the thermal management process. A thermal zone appears to
> be a sensor while it is not.
>
> In order to set the scene for multiple thermal sensors aggregated into
> a single thermal zone. Rename the thermal_zone_ops to
> thermal_sensor_ops, that will appear clearyl the thermal zone is not a

to make it clear

> sensor but an abstraction of one [or multiple] sensor(s).
>
> Cc: Alexandre Bailon <abailon@xxxxxxxxxxxx>
> Cc: Kevin Hilman <khilman@xxxxxxxxxxxx>
> Cc; Eduardo Valentin <eduval@xxxxxxxxxx>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

> drivers/thermal/rcar_thermal.c | 4 ++--

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds